I had this exact same issue of the spring hitting the spring cover on one side of the car. This happened was after I had replaced everything in the front suspension. including the springs, upper and lower control arms, shocks, all bushings, all the tie rods, rotors, calipers, brake hoses etc.. It drove me nuts for a while and I disassembled that side of the suspension 3 times trying to look for an answer. I finally figured out that the spring cover was bent, don't ask me why it did not hit before I replaced everything. From the photo yours also looks to be bent. I figured it out as when I looked at the drivers side spring cover and compared it the passenger side one, I could see that the passenger side one was further into the shock tower as the lower part of it was bent in an S shape like your is. Look at your upper photo and look at the lower part of the spring cover, right on the lower stud, you can see clearly that it is bent inward in an S shape. If you look at the other side, that part is basically straight. Just take it off and grab a big hammer and a piece of wood, lay the spring cover on top of the flat piece of wood and go to town on it.
After seeing what happened to you, I finally understand what happened to me. The front suspension, steering and brakes, was the first thing I did when I bought the car. I had never understood how or why that cover was bent inward like that when it did not look like anything had ever touched it. My car had a nasty hit on the front crossmember on the passenger side, which bent the crossmember and the strut rod. When I did the front end I put a new strut rod in. I now realize, after looking at your car, that if these cars are hit hard on one side of the lower suspension, that the hit will travel through front frame and into the apron/shock towers and bend the spring cover. The front frame rail on my car is a little bent, you should check yours. My car was hit in the crossmember which bent the strut rod and pushed the lower control arm back and bent it a little bit, all that force bent the spring cover and my front frame rail. Yours was kind of opposite, in which your lower control arm hit, but that force would travel forward through the strut rod and into the crossmember, basically imparting all that force to the the lower frame rail and into the aprons, shock towers, and that spring cover.
